fix(core): handle Result type after get_actions sync conversion #3846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
yousefsaad12
changed the title
- Added ? operator to handle Result<Vec<Action>, DeltaTableError> - Removed .await calls since get_actions is now synchronous - Fixed pattern matching from &&Action to Action in filter predicates Signed-off-by: Yousef Saad <[email protected]>
yousefsaad12
force-pushed
the
fix/get-actions-result-handling
branch
from
12324a2 to
7b14c25
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
==========================================
- Coverage 73.78% 73.76% -0.03%
==========================================
Files 152 152
Lines 39144 39116 -28
Branches 39144 39116 -28
==========================================
- Hits 28883 28853 -30
- Misses 8987 8989 +2
Partials 1274 1274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtyler
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed compilation errors that occurred after
get_actionswas converted from async to sync as part of #3837. The refactoring changed the function signature but left several call sites using the old async pattern, resulting in type mismatches and compilation failures across multiple modules.Changes Made
?operator to properly handleResult<Vec<Action>, DeltaTableError>returned byget_actions().awaitcalls sinceget_actionsis now synchronous and no longer returns aFuture&&ActiontoActionin filter predicates to match the updated return type structureFiles Modified
crates/core/src/kernel/transaction/conflict_checker.rs- Added?operator and fixed iterator pattern matchingcrates/core/src/operations/load_cdf.rs- Added?operator to handle Result typecrates/core/src/operations/merge/mod.rs- Removed.awaitcalls (3 locations)crates/core/src/operations/write/mod.rs- Fixed pattern matching in filter predicates (3 locations)Testing
All compilation errors have been resolved. Testing results:
cargo fmtcargo clippywith no new warningsImpact
This change addresses compilation failures without altering runtime behavior or public API surface. The modifications are minimal and focused solely on adapting call sites to the new synchronous
get_actionsfunction signature.Related Issue(s)
get_actionsasync-to-sync conversionDocumentation
No documentation changes are required as this is an internal implementation change that maintains backward compatibility in functionality while adapting to the new synchronous API.